Skip to content

doc: update outdated nodejs.org guide links - #65394

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
HoonDongKang:doc-fix-broken-guide-links
Aug 21, 2026
Merged

doc: update outdated nodejs.org guide links#65394
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
HoonDongKang:doc-fix-broken-guide-links

Conversation

@HoonDongKang

@HoonDongKang HoonDongKang commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Update outdated nodejs.org/en/docs/guides/... links to their current nodejs.org/learn/... destinations.

  1. doc/api/cli.md
- https://nodejs.org/en/docs/guides/debugging-getting-started/#security-implications
+ https://nodejs.org/learn/getting-started/debugging#security-implications
  1. doc/api/n-api.md
- https://nodejs.org/en/docs/guides/abi-stability/
+ https://nodejs.org/learn/modules/abi-stability
  1. doc/api/timers.md
- https://nodejs.org/en/docs/guides/event-loop-timers-and-nexttick/#setimmediate-vs-settimeout
+ https://nodejs.org/learn/asynchronous-work/event-loop-timers-and-nexttick#setimmediate-vs-settimeout

@HoonDongKang
doc: update outdated nodejs.org guide links
beda2dd 
Update outdated `nodejs.org/en/docs/guides/...` links
to their current `nodejs.org/learn/...` destinations.

Signed-off-by: HoonDongKang <d159123@naver.com>
@nodejs-github-bot

nodejs-github-bot commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/node-api

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 19, 2026
MikeMcC399
MikeMcC399 approved these changes Aug 19, 2026
View reviewed changes

@MikeMcC399 MikeMcC399 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for catching the 404 errors!

There are however some other bad links on:

doc/api/cli.md
#environment-variables_1 (underscore instead of -)
https://www.memorymanagement.org/ expired certificate

doc/api/n-api.md
https://gyp.gsrc.io - site no longer exists

Since these issues don't concern nodejs.org, I'd suggest handling them in separate PRs.

I used markdown-link-check directly on the *.md files to check.

@MikeMcC399 MikeMcC399 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 19, 2026
@HoonDongKang

HoonDongKang commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for pointing these out!

I also ran markdown-link-check and confirmed the failures.

I initially considered addressing all link-check failures under doc/api in a single PR. However, that would have involved changes to many files and made the scope of the PR too broad.

Therefore, I split the fixes into two focused follow-up PRs by file, as suggested:

@MikeMcC399 MikeMcC399 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 20, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 11a9998 into nodejs:main Aug 21, 2026
27 checks passed
@nodejs-github-bot

nodejs-github-bot commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Landed in 11a9998

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@MikeMcC399 MikeMcC399 MikeMcC399 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@HoonDongKang @nodejs-github-bot @jasnell @lpinca @MikeMcC399